Skip to content
This repository was archived by the owner on Sep 11, 2020. It is now read-only.

"0 Comments" and link colors#42

Closed
bskendig wants to merge 4 commits intoCodeinwp:masterfrom
bskendig:master
Closed

"0 Comments" and link colors#42
bskendig wants to merge 4 commits intoCodeinwp:masterfrom
bskendig:master

Conversation

@bskendig
Copy link
Copy Markdown

@bskendig bskendig commented Aug 14, 2014

Change "0 Comment" to "0 Comments".
Add ability to change link colors.

@bskendig bskendig changed the title Change "0 Comment" to "0 Comments" "0 Comments" and link colors Aug 14, 2014
@victorperin
Copy link
Copy Markdown
Contributor

victorperin commented Aug 14, 2014

Alright, thanks a lot! =D
Now, we must change all PO/MO files for "0 Comments" in other languages.
Also, you make-me understand how to create config options, so thanks again! =)

@bskendig
Copy link
Copy Markdown
Author

bskendig commented Aug 15, 2014

You're welcome! I will leave the translations to you, because I don't know those languages.

@victorperin
Copy link
Copy Markdown
Contributor

victorperin commented Aug 15, 2014

Alright, I just know Portuguese... =P
I'll make a pull request in your branch. If anyone else knows, just push it...

@bskendig
Copy link
Copy Markdown
Author

bskendig commented Aug 15, 2014

It's possible the other languages might not even be wrong.

@victorperin
Copy link
Copy Markdown
Contributor

victorperin commented Aug 15, 2014

alright, but i think the best practice is just check it... Right now, I don't have time, so this weekend I'll se those translations...

@bskendig
Merge branch 'master' of https://github.com/yoarts/flat
fb28f36 
Conflicts:
	functions.php
	inc/customizer.php
@bskendig
Copy link
Copy Markdown
Author

bskendig commented Oct 8, 2014

I notice you haven't pulled this request yet, and a message above says that the build failed ... what went wrong?

@victorperin
Copy link
Copy Markdown
Contributor

victorperin commented Nov 24, 2014

Just @yoarts can pull your request, so we need to wait him...
About the error, i think Travis CI is misconfigured, I'm going to make an issue for this.
And, thanks for your code!

@mohalani
Copy link
Copy Markdown

mohalani commented Feb 4, 2015

This should be changed from "0 Comments" to "No comment", because either do not make much sense and are contextually wrong

@victorperin
Copy link
Copy Markdown
Contributor

victorperin commented Feb 15, 2015

Alright, @bskendig can you remake this pull request? A lot of code changed.

@bskendig
Copy link
Copy Markdown
Author

bskendig commented Feb 15, 2015

Sorry, no, that was a long time ago and I've already moved on. It's a trivial enough fix if someone else wants to take it up, though.

@thanhluu thanhluu closed this Feb 17, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bskendig @victorperin @mohalani @thanhluu